Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade urfave/cli to v1 to enable more flexible parsing #154

Merged
merged 4 commits into from
Jun 28, 2021

Conversation

danxmoran
Copy link
Contributor

Closes #147

I've confirmed that rebasing #150 onto this branch fixes the breaking change (I can pass the stack ID before or after the -f flag).

@danxmoran danxmoran force-pushed the dm-try-downgrade-urfave branch from c559ca0 to 3da4837 Compare June 28, 2021 16:07
@williamhbaker
Copy link
Contributor

Everything looks good in the code as far as I can tell, but I have a higher level question as well - Is the issue with v2 breaking the old CLI examples really just related to examples - docs examples I'm guessing? I'm thinking along the lines of updating the examples vs. using an older version of urfave.

Updating a bunch of docs wouldn't be very much fun but that might have some pros instead of working with an older/not maintained package. If there's more significant breakages that would occur with the new behavior maybe it would outweigh that though.

@danxmoran
Copy link
Contributor Author

Is the issue with v2 breaking the old CLI examples really just related to examples - docs examples I'm guessing?

Yes, across our public docs, help text, and (I'd guess) blog posts. I think it's something we could eventually phase out w/ proper deprecation notice, but I think it'd be a big lift to update everything in time for the new CLI release (esp. given the time pressure). I think minimizing the number of big incompatibilities will be important to get people to go through the effort of migrating to the new version; we're still paying for some big mismatches between v1 and v2, I don't want to add another layer of problems between v2.0 and v2.1.

I checked the release dates of urfave/cli. v2.3.0 and v1.22.5 were released within a day of each other, so I don't think we're regressing to a version that hasn't seen any maintenance.

@danxmoran danxmoran requested a review from williamhbaker June 28, 2021 17:54
@williamhbaker
Copy link
Contributor

williamhbaker commented Jun 28, 2021

Makes sense to me, especially regarding reducing the friction from v2.0 to 2.1!

@danxmoran danxmoran merged commit ead44e4 into main Jun 28, 2021
@danxmoran danxmoran deleted the dm-try-downgrade-urfave branch June 28, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try downgrading to urfave/cli v1
2 participants