-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: downgrade urfave/cli to v1 to enable more flexible parsing #154
Conversation
c559ca0
to
3da4837
Compare
Everything looks good in the code as far as I can tell, but I have a higher level question as well - Is the issue with v2 breaking the old CLI examples really just related to examples - docs examples I'm guessing? I'm thinking along the lines of updating the examples vs. using an older version of Updating a bunch of docs wouldn't be very much fun but that might have some pros instead of working with an older/not maintained package. If there's more significant breakages that would occur with the new behavior maybe it would outweigh that though. |
Yes, across our public docs, help text, and (I'd guess) blog posts. I think it's something we could eventually phase out w/ proper deprecation notice, but I think it'd be a big lift to update everything in time for the new CLI release (esp. given the time pressure). I think minimizing the number of big incompatibilities will be important to get people to go through the effort of migrating to the new version; we're still paying for some big mismatches between v1 and v2, I don't want to add another layer of problems between v2.0 and v2.1. I checked the release dates of |
Makes sense to me, especially regarding reducing the friction from v2.0 to 2.1! |
Closes #147
I've confirmed that rebasing #150 onto this branch fixes the breaking change (I can pass the stack ID before or after the
-f
flag).