Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove console output when disposing WriteApi #101

Merged
merged 2 commits into from
Jun 10, 2020
Merged

fix: Remove console output when disposing WriteApi #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
120adeb
Remove console output when disposing WriteApi
kvakulo Jun 9, 2020
0143f83
Update CHANGELOG.md
bednar Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
## 1.9.0 [unreleased]

### API

1. [#94](https://github.com/influxdata/influxdb-client-csharppull/94): Update swagger to latest version

### Bug Fixes
1. [#100](https://github.com/influxdata/influxdb-client-csharp/pull/100): Thread-safety disposing of clients
1. [#101](https://github.com/influxdata/influxdb-client-csharp/pull/101/): Use Trace output when disposing WriteApi

## 1.8.0 [2020-05-15]

Expand Down
6 changes: 3 additions & 3 deletions Client/WriteApi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,12 +194,12 @@ protected internal WriteApi(
exception =>
{
_disposed = true;
Console.WriteLine($"The unhandled exception occurs: {exception}");
Trace.WriteLine($"The unhandled exception occurs: {exception}");
},
() =>
{
_disposed = true;
Console.WriteLine("The WriteApi was disposed.");
Trace.WriteLine("The WriteApi was disposed.");
});
}

Expand Down Expand Up @@ -649,4 +649,4 @@ private bool Equals(BatchWriteOptions other)
Precision == other.Precision;
}
}
}
}