Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplified generated code and OSS swagger sync #353

Merged
merged 1 commit into from
Sep 21, 2022
Merged

feat: simplified generated code and OSS swagger sync #353

merged 1 commit into from
Sep 21, 2022

Conversation

vlastahajek
Copy link
Contributor

@vlastahajek vlastahajek commented Sep 7, 2022 •
edited
Loading

Proposed Changes

  • Simplified methods of generated server API client stub (breaking change):
    • Each server call has a single function with all the necessary code
    • Each server call function takes all arguments in a single wrapper struct
    • Functions return directly a type, instead of a response wrapper struct.
  • Synced generated server API with the latest oss.yml.
  • Interface Client has been extended with APIClient() function. (breaking change)

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are in semantic format

@vlastahajek vlastahajek added this to the v2.11.0 milestone Sep 7, 2022
@vlastahajek vlastahajek requested a review from sranka September 7, 2022 15:52
@vlastahajek vlastahajek changed the title feat: simplified generated code feat: simplified generated code and OSS swagger sync Sep 8, 2022
@vlastahajek vlastahajek requested a review from bednar September 13, 2022 12:13
sranka
sranka requested changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@sranka sranka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only request a few documentation changes so that all the changes are easier to understand.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
sranka
sranka reviewed Sep 20, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@vlastahajek vlastahajek requested a review from sranka September 20, 2022 14:11
@vlastahajek vlastahajek merged commit 388612e into influxdata:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sranka sranka sranka approved these changes

@bednar bednar Awaiting requested review from bednar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vlastahajek @sranka