Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mapping Number types to POJO query output #414

Merged
merged 5 commits into from
Sep 17, 2022
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Sep 7, 2022

Closes #410

Proposed Changes

Fixed mapping aggregated results (changed type) from InfluxDB.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rhajek September 7, 2022 09:56
@bednar bednar marked this pull request as ready for review September 7, 2022 10:01
bednar added a commit to influxdata/influxdb-client-csharp that referenced this pull request Sep 8, 2022
@bednar bednar requested review from michaelahojna and removed request for rhajek September 8, 2022 11:53
Copy link
Contributor

@michaelahojna michaelahojna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bednar thanks for your PR, please add also mapping for short and float types.

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022

Codecov Report

Base: 88.22% // Head: 88.32% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (9712c87) compared to base (c664c23).
Patch coverage: 77.77% of modified lines in pull request are covered.

❗ Current head 9712c87 differs from pull request most recent head d2eb05e. Consider uploading reports for the commit d2eb05e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #414      +/-   ##
============================================
+ Coverage     88.22%   88.32%   +0.10%     
+ Complexity      777      775       -2     
============================================
  Files           172      172              
  Lines          6987     6987              
  Branches        375      375              
============================================
+ Hits           6164     6171       +7     
+ Misses          712      703       -9     
- Partials        111      113       +2     
Impacted Files Coverage Δ
.../com/influxdb/query/internal/FluxResultMapper.java 73.86% <77.77%> (+7.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bednar bednar merged commit d46c240 into master Sep 17, 2022
@bednar bednar deleted the mapper-casting branch September 17, 2022 04:00
@bednar bednar added this to the 6.6.0 milestone Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem Mapping Long fields
3 participants