chore(deps): update scala to 2.13.9, remove scala coverage report plugin #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 88.37% // Head: 88.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #436 +/- ##
=========================================
Coverage 88.37% 88.38%
- Complexity 776 778 +2
=========================================
Files 172 172
Lines 7004 6999 -5
Branches 379 377 -2
=========================================
- Hits 6190 6186 -4
+ Misses 694 693 -1
Partials 120 120
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
What security is there actually with Scala 2.13.8? |
michaelahojna
approved these changes
Oct 4, 2022
jozic
reviewed
Oct 9, 2022
| <artifactId>scoverage-maven-plugin</artifactId> | ||
| <version>${scoverage-maven-plugin.version}</version> | ||
| <configuration> | ||
| <scalaVersion>${scala.version}</scalaVersion> |
There was a problem hiding this comment.
i believe you can hardcode 2.13.8 here and it still should work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #433
Closes #435
Proposed Changes
2.13.9scoverage-maven-pluginbecause is no longer supported for Scala2.13.9- for more info seescoverage-maven-pluginis not compatible with 2.13.9 #433Checklist
mvn testcompletes successfully