Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensuring aws lambda compatible zip #312

Merged
merged 2 commits into from
Aug 18, 2021
Merged

fix: ensuring aws lambda compatible zip #312

merged 2 commits into from
Aug 18, 2021

Conversation

russorat
Copy link
Contributor

i was following the instructions here: https://github.com/influxdata/influxdb-client-python/tree/master/docker/aws_lambda_layer#readme

but noticed that the zip file created contained files that start with the /python/ prefix. To be compatible with aws lambda, the packages should be in the root.

previous zip structure:

(base) ➜  kinesisToInfluxDBCloud unzip -vl python.zip | head
Archive:  python.zip
 Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
--------  ------  ------- ---- ---------- ----- --------  ----
       0  Stored        0   0% 08-17-2021 22:25 00000000  python/
       0  Stored        0   0% 08-17-2021 22:25 00000000  python/rx/
       0  Stored        0   0% 08-17-2021 22:25 00000000  python/rx/py.typed
       0  Stored        0   0% 08-17-2021 22:25 00000000  python/rx/core/
    9565  Defl:N     1855  81% 08-17-2021 22:25 c968ac4a  python/rx/core/typing.py
       0  Stored        0   0% 08-17-2021 22:25 00000000  python/rx/core/observer/
       0  Stored        0   0% 08-17-2021 22:25 00000000  python/rx/core/observer/__pycache__/

new zip structure:

(base) ➜  kinesisToInfluxDBCloud unzip -vl python.zip | head
Archive:  python.zip
 Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
--------  ------  ------- ---- ---------- ----- --------  ----
       0  Stored        0   0% 08-17-2021 22:25 00000000  rx/
       0  Stored        0   0% 08-17-2021 22:25 00000000  rx/py.typed
       0  Stored        0   0% 08-17-2021 22:25 00000000  rx/core/
    9565  Defl:N     1855  81% 08-17-2021 22:25 c968ac4a  rx/core/typing.py
       0  Stored        0   0% 08-17-2021 22:25 00000000  rx/core/observer/
       0  Stored        0   0% 08-17-2021 22:25 00000000 rx/core/observer/__pycache__/

Proposed Changes

Briefly describe your proposed changes:

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #312 (762327b) into master (f455a87) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #312   +/-   ##
=======================================
  Coverage   92.55%   92.55%           
=======================================
  Files          27       27           
  Lines        2204     2204           
=======================================
  Hits         2040     2040           
  Misses        164      164           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f455a87...762327b. Read the comment docs.

@bednar bednar self-requested a review August 18, 2021 05:48
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar merged commit 99bd791 into master Aug 18, 2021
@bednar bednar deleted the fix-aws-zip branch August 18, 2021 06:09
@bednar bednar added this to the 1.20.0 milestone Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants