Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use pandas.concat() instead of deprecated DataFrame.append() #407

Merged
merged 2 commits into from
Feb 17, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Feb 16, 2022

Closes #406

Proposed Changes

Use pandas.concat() instead of deprecated DataFrame.append():

image
https://pandas.pydata.org/docs/dev/whatsnew/v1.4.0.html#deprecated-dataframe-append-and-series-append

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #407 (3f82572) into master (52a9d02) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #407   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files          28       28           
  Lines        2506     2506           
=======================================
  Hits         2337     2337           
  Misses        169      169           
Impacted Files Coverage Δ
influxdb_client/client/flux_csv_parser.py 98.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52a9d02...3f82572. Read the comment docs.

@bednar bednar marked this pull request as ready for review February 16, 2022 07:08
@bednar bednar requested a review from rhajek February 16, 2022 07:08
@bednar bednar force-pushed the pandas_deprecation branch from 1d34114 to 3f82572 Compare February 17, 2022 11:50
@bednar bednar merged commit 74befc3 into master Feb 17, 2022
@bednar bednar deleted the pandas_deprecation branch February 17, 2022 13:17
@bednar bednar added this to the 1.26.0 milestone Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecated calls in flux_csv_parser.py
3 participants