Skip to content

feat: move-setuptools-build-dependency #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2025

Conversation

NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented May 27, 2025

Close 695

Proposed Changes

  • Move the "setuptools" package to build dependency to accommodate new check from the homeassistant library

_ Before the fix
Screenshot 2025-06-01 at 09 11 22

_ After the fix: I think the new error message means we have had solved the dependency issue, check out "home-assistant-core/script/hassfest/requirements.py" line 169. The new error message is for the homeassistant team
Screenshot 2025-06-01 at 09 17 20

_ My steps to reproduce the issue:

  • Checkout Home assistant core repo

  • Run "source venv/bin/activate"

  • Run "python3 -m script.gen_requirements_all && pip3.13 install -r requirements_all.txt --break-system-package"

  • Run "python3 -m script.hassfest --integration-path "home-assistant-core/homeassistant/components/influxdb" --requirement"

  • My steps to fix

  • Build influxdb-client-python with the latest change -> Upload to PyPi Link. After that, replace the content of "homeassistant/components/influxdb/manifest.json" like this
    manifest.json

  • Run the same steps as when reproducing the issue again

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this May 27, 2025
@NguyenHoangSon96 NguyenHoangSon96 changed the title Add initial work in progress for new feature feat: move-setuptools-build-dependency May 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.36%. Comparing base (4ce3746) to head (48619c4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #696   +/-   ##
=======================================
  Coverage   90.36%   90.36%           
=======================================
  Files          40       40           
  Lines        3541     3541           
=======================================
  Hits         3200     3200           
  Misses        341      341           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NguyenHoangSon96 NguyenHoangSon96 linked an issue May 28, 2025 that may be closed by this pull request
@NguyenHoangSon96 NguyenHoangSon96 marked this pull request as ready for review June 2, 2025 01:43
Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeated steps to reproduce and resolve error message in home-assistant. (Note I used Sonnh's build in PyPi). It is working for me. Changes all make sense. 🚴 🏁

@NguyenHoangSon96 NguyenHoangSon96 merged commit feb97ee into master Jun 3, 2025
18 checks passed
@NguyenHoangSon96 NguyenHoangSon96 deleted the feat/move-setuptools-build-dependency branch June 3, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package setuptools should not be a runtime dependency
3 participants