-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare code changes to support UDP async #239
Conversation
Current coverage is 68.49% (diff: 68.18%)@@ master #239 diff @@
==========================================
Files 10 10
Lines 576 584 +8
Methods 0 0
Messages 0 0
Branches 68 69 +1
==========================================
+ Hits 395 400 +5
- Misses 147 150 +3
Partials 34 34
|
Build fails ! |
No one unit-test is failing: |
@majst01 build fail is caused by sometime UDP's write executed on server is after http's query. so I may sleep 2s to avoid the fail. |
@majst01 It is ok now. You can go ahead with your review. If the similar build error happen again, I may change the design for the test cases to avoid sleeping 2s but just try times with interval. |
I'm still not sure why we need batchprocessing for udp because udp is fire and forget anyway. Can you please provide some metrics which show the gains of using batchprocessing for udp. |
@majst01 There are three points for batch processing goal (1) improve performance with batch (2) to avoid pass same tags into every points. this point is no relationships for performance. It will make api users more easier to use it: such as : if we not support batch, we may write code when existed many same tags as followed:
the if we support batch:
(3) http support it. we should keep udp support too. What's more, this PR take more focuses on async support. not just limit to batch. maybe I need to change title. And the next PR is to support async UDP with little code changes and more test cases.. Then we can consider how to support UdpBatches instead of List BTW: When we complete all UDP‘s support, I will provide one compare with http with udp through as everyone know udp is must be faster than http. Thanks again. WDYT? |
@majst01 Can you continue this PR now so that I can complete support UDP async today with little code changes. I pay more attention of this PR's reason is that I can't go ahead to fix other issues to resolve possible code conflict with other fixs' commits. So can you also take more time to pay more attention on this PR when you are free. Then we would completed all big features such as UDP and Gzip. Then we can take a rest! |
This is another PR to prepare supporting UDP async.
Create this PR's goal to make sure we can step by step with limit code changes for clear review.
abstract batch entry to support both http batch entry and udp batch entry.
This will avoid use the same batch entry due to http batch entry doesn't need udp port and udp patch doesn't need dbname or rp.
I doesn't add any unit tests(so decrease coverage by 0.42%) due to just refactor and no use the UdpBatchEntry just now. it is just one common java bean without any logical.
I will add tests together with the next PR when support UDP patch officially.