Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write consistency can be set for batching mode #293

Closed

Conversation

jganoff
Copy link
Contributor

@jganoff jganoff commented Feb 28, 2017

The consistently level can be configured for asynchronous writes. The default was not changed and is still ONE. It can be explicitly set via InfluxDB.enableBatch(int, int, TimeUnit, ConsistencyLevel). See #289 for more context.

import java.util.concurrent.TimeUnit;
import java.util.function.Consumer;

import com.google.common.util.concurrent.Uninterruptibles;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not reorg imports.

@majst01
Copy link
Collaborator

majst01 commented Feb 28, 2017

Needs rebase.

@codecov-io
Copy link

codecov-io commented Feb 28, 2017

Codecov Report

Merging #293 into master will increase coverage by 0.23%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #293      +/-   ##
============================================
+ Coverage     78.65%   78.88%   +0.23%     
- Complexity      133      134       +1     
============================================
  Files            11       11              
  Lines           712      720       +8     
  Branches         77       77              
============================================
+ Hits            560      568       +8     
  Misses          109      109              
  Partials         43       43
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/InfluxDB.java 100% <ø> (ø) 0 <0> (ø)
...rc/main/java/org/influxdb/impl/BatchProcessor.java 98.05% <100%> (+0.09%) 17 <0> (ø)
src/main/java/org/influxdb/impl/InfluxDBImpl.java 81.25% <100%> (+0.27%) 42 <2> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30fa0ee...76347c0. Read the comment docs.

@jganoff jganoff force-pushed the feature-289-batch-write-consistency branch from e94a512 to cb7f2ef Compare February 28, 2017 07:48
@jganoff jganoff force-pushed the feature-289-batch-write-consistency branch from cb7f2ef to 76347c0 Compare February 28, 2017 07:53
@phantc67
Copy link

phantc67 commented Dec 4, 2017

Can I modify to override those parameters in InfluxDBImpl.java file?

@lxhoan lxhoan added this to the 2.11 milestone May 14, 2018
@lxhoan
Copy link
Contributor

lxhoan commented May 15, 2018

@majst01 , I think we can close this PR because the PR #385 has addressed it

@lxhoan lxhoan self-assigned this May 15, 2018
@majst01 majst01 closed this May 15, 2018
@majst01
Copy link
Collaborator

majst01 commented May 15, 2018

Duplicate of #385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants