Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support map queryresult groupby #345

Merged
merged 2 commits into from
Jun 28, 2017
Merged

Added support map queryresult groupby #345

merged 2 commits into from
Jun 28, 2017

Conversation

fmachado
Copy link
Contributor

When the "GROUP BY" clause is used, "tags" are returned as Map<String,String>.
Accordingly with InfluxDB documentation https://docs.influxdata.com/influxdb/v1.2/concepts/glossary/#tag-value, "TAG" is always a String so currently we are not supporting (at)Column annotation on non-String Class fields.
This solves the issue #343.

@fmachado fmachado changed the title Added support map queryresult groupby #343 Added support map queryresult groupby Jun 28, 2017
@codecov-io
Copy link

Codecov Report

Merging #345 into master will increase coverage by 0.11%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #345      +/-   ##
============================================
+ Coverage     83.33%   83.44%   +0.11%     
- Complexity      197      199       +2     
============================================
  Files            16       16              
  Lines           900      906       +6     
  Branches         88       91       +3     
============================================
+ Hits            750      756       +6     
+ Misses          109      107       -2     
- Partials         41       43       +2
Impacted Files Coverage Δ Complexity Δ
...n/java/org/influxdb/impl/InfluxDBResultMapper.java 87.59% <75%> (-1.03%) 45 <0> (+2)
src/main/java/org/influxdb/dto/QueryResult.java 96.29% <0%> (+3.7%) 6% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f601cc...eff316f. Read the comment docs.

@majst01 majst01 merged commit a48e981 into influxdata:master Jun 28, 2017
@majst01
Copy link
Collaborator

majst01 commented Jun 28, 2017

@fmachado would you mind adding a Changelog entry and extended documentation ?

btw: thanks for this.

@bukajsytlos
Copy link

Hello.
We really need use this feature.
I would like to ask when you plan to release this?

Thank you.

@majst01 majst01 added this to the 2.8 milestone Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants