Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #445 #477

Closed
wants to merge 1 commit into from
Closed

fix issue #445 #477

wants to merge 1 commit into from

Conversation

lxhoan
Copy link
Contributor

@lxhoan lxhoan commented Jul 25, 2018

@fmachado , I followed option (1) as discussed. I also reuse your test code (provided in the original issue) for unit test, tks, please help to review

@lxhoan lxhoan requested review from majst01 and fmachado July 25, 2018 07:10
@codecov-io
Copy link

codecov-io commented Jul 25, 2018

Codecov Report

Merging #477 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #477      +/-   ##
============================================
+ Coverage     86.91%   86.93%   +0.02%     
+ Complexity      304      303       -1     
============================================
  Files            20       20              
  Lines          1292     1294       +2     
  Branches        134      134              
============================================
+ Hits           1123     1125       +2     
- Misses          110      111       +1     
+ Partials         59       58       -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/impl/InfluxDBImpl.java 88.88% <100%> (+0.67%) 69 <0> (ø) ⬇️
src/main/java/org/influxdb/InfluxDBException.java 87.27% <0%> (-3.64%) 11% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59e4e6...9c893b8. Read the comment docs.

@majst01
Copy link
Collaborator

majst01 commented Jul 25, 2018

Needs rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants