Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overriding Accept-Encoding header when gzip is disabled #625

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Overriding Accept-Encoding header when gzip is disabled #625

wants to merge 1 commit into from

Conversation

eric-musliner
Copy link

@eric-musliner eric-musliner commented Oct 1, 2019 •
edited
Loading

  • When gzip is disabled, do not add Accept-Encoding gzip header to request. (Overrided with identity for Accept-Encoding)
  • In specific environments/deployments the addition of this encoding type causes issues

Overriding Accept-Encoding header when gzip is disabled
4c588bd 
 - When gzip is disabled, do not add Accept-Encoding header to request. (Overrided with identity for Accept-Encoding)
 - In specific environments/deployments the addition of this encoding type causes issues
@majst01
Copy link
Collaborator

majst01 commented Oct 1, 2019

Hi,

got your point, can you please add a test that ensures the correctness of the resulting header in this case, a additional entry in the CHANGELOG.md would also be nice.

@majst01
Copy link
Collaborator

majst01 commented Jan 22, 2020

Any updates here ?

@eric-musliner
Copy link
Author

Sorry, I haven't had the time to figure out to implement a test for this. It wasn't as straight forward as I initially thought. If you have any ideas on how to test this it would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eric-musliner @majst01