Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling newline characters in tags #703

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BrentonPoke
Copy link

Hopefully this is the last one I have to do to clean up #684. Another attempt was made at #702, but checkstyle made things...difficult.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2020

Codecov Report

Merging #703 into master will increase coverage by 0.08%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #703      +/-   ##
============================================
+ Coverage     59.09%   59.18%   +0.08%     
- Complexity      413      419       +6     
============================================
  Files            69       70       +1     
  Lines          2540     2548       +8     
  Branches        268      270       +2     
============================================
+ Hits           1501     1508       +7     
  Misses          972      972              
- Partials         67       68       +1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/dto/BatchPoints.java 87.87% <75.00%> (-0.67%) 24.00 <0.00> (ø)
src/main/java/org/influxdb/dto/Point.java 92.56% <100.00%> (+0.03%) 52.00 <0.00> (ø)
...rc/main/java/org/influxdb/dto/utils/CheckTags.java 100.00% <100.00%> (ø) 6.00 <6.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6107962...604b1cf. Read the comment docs.

@fmachado fmachado self-assigned this Sep 28, 2020
@BrentonPoke
Copy link
Author

@fmachado So how is this one? Good enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants