Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error msg obscure when connect url port miss #769

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

camilesing
Copy link

see #768

Copy link
Collaborator

@majst01 majst01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution, appreciate that.
You should leave formatting as is, and change only what is required what you want to achieve. Otherwise reviewing is not possible.

Also "*" imports are not accepted in the project

@camilesing
Copy link
Author

Ok, I did @majst01

@majst01
Copy link
Collaborator

majst01 commented Sep 15, 2021

Will review after release in the next days, be patient

@camilesing
Copy link
Author

camilesing commented Sep 15, 2021

@majst01 Er, I think it's a great improvement, it can void someone to take sometime get understand why client not work. so it should merge to the next release version. what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants