This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Add support for PHP 8 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pvsaintpe
approved these changes
Dec 24, 2020
|
Greetings dear authors/contributors, @thecodeassassin, @danibrutal, @andreyvital, @Nyholm, and more ... I appeal to those who can merge, please, push this pull request to the master. I really need support for PHP 8.0, and I really don't want to fork and insert crutches into my project. Thank you in advance. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 8.0 to the supported versions in
composer.json. No client code updates appear to be required.This also upgrades to PHPUnit 9.5, which is the lowest version supporting both tests and code coverage on PHP 8, and adds a plugin to provide an assertion which was removed from the base project. The configuration file and tests have been updated to replace deprecations and now pass cleanly. The Travis config was also updated to test on PHP 7.3-8.0, the versions supported by PHPUnit 9.