feat(kv): enable reading from URM by user index (#17618)

CHANGELOG.md

@@ -4,6 +4,8 @@
 
 ### Bug Fixes
 
+1. [17618](https://github.com/influxdata/influxdb/pull/17618): Add index for URM by user ID to improve lookup performance
+
 ### UI Improvements
 
 1. [17714](https://github.com/influxdata/influxdb/pull/17714): Cloud environments no longer render markdown images, for security reasons.

kv/service.go

@@ -79,7 +79,7 @@ func NewService(log *zap.Logger, kv Store, configs ...ServiceConfig) *Service {
 				id, _ := urm.UserID.Encode()
 				return id, nil
 			},
-		)),
+		), WithIndexReadPathEnabled),
 		disableAuthorizationsForMaxPermissions: func(context.Context) bool {
 			return false
 		},
@@ -115,18 +115,13 @@ func NewService(log *zap.Logger, kv Store, configs ...ServiceConfig) *Service {
 		s.clock = clock.New()
 	}
 
-	if s.Config.URMByUserIndexReadPathEnabled {
-		WithIndexReadPathEnabled(s.urmByUserIndex)
-	}
-
 	return s
 }
 
 // ServiceConfig allows us to configure Services
 type ServiceConfig struct {
-	SessionLength                 time.Duration
-	Clock                         clock.Clock
-	URMByUserIndexReadPathEnabled bool
+	SessionLength time.Duration
+	Clock         clock.Clock
 }
 
 // AutoMigrationStore is a Store which also describes whether or not

kv/urm_test.go

@@ -28,22 +28,10 @@ func TestBoltUserResourceMappingService(t *testing.T) {
 	influxdbtesting.UserResourceMappingService(initURMServiceFunc(NewTestBoltStore), t)
 }
 
-func TestBoltUserResourceMappingService_WithUserIndex(t *testing.T) {
-	influxdbtesting.UserResourceMappingService(initURMServiceFunc(NewTestBoltStore, kv.ServiceConfig{
-		URMByUserIndexReadPathEnabled: true,
-	}), t)
-}
-
 func TestInmemUserResourceMappingService(t *testing.T) {
 	influxdbtesting.UserResourceMappingService(initURMServiceFunc(NewTestBoltStore), t)
 }
 
-func TestInmemUserResourceMappingService_WithUserIndex(t *testing.T) {
-	influxdbtesting.UserResourceMappingService(initURMServiceFunc(NewTestBoltStore, kv.ServiceConfig{
-		URMByUserIndexReadPathEnabled: true,
-	}), t)
-}
-
 type userResourceMappingTestFunc func(influxdbtesting.UserResourceFields, *testing.T) (influxdb.UserResourceMappingService, func())
 
 func initURMServiceFunc(storeFn func(*testing.T) (kv.Store, func(), error), confs ...kv.ServiceConfig) userResourceMappingTestFunc {