Skip to content

Commit

Permalink
stubbing out drop server command
Browse files Browse the repository at this point in the history
  • Loading branch information
corylanou authored and levicook committed Apr 19, 2015
1 parent e5aa5cd commit ece6247
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 2 deletions.
7 changes: 7 additions & 0 deletions commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,15 @@ const (

// Privilege messages
setPrivilegeMessageType = messaging.MessageType(0x90)

// Server messages
dropServerMessageType = messaging.MessageType(0x100)
)

type dropServerCommand struct {
NodeID uint64 `json:"nodeid"`
}

type createDataNodeCommand struct {
URL string `json:"url"`
}
Expand Down
4 changes: 2 additions & 2 deletions influxdb.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ var (
// attempting to join another data node when no data nodes exist yet
ErrDataNodeNotFound = errors.New("data node not found")

// ErrDataNodeRequired is returned when using a blank data node id.
ErrDataNodeRequired = errors.New("data node required")
// ErrServerNodeIDRequired is returned when using a zero server node id.
ErrServerNodeIDRequired = errors.New("server node id must be greater than 0")

// ErrDatabaseNameRequired is returned when creating a database without a name.
ErrDatabaseNameRequired = errors.New("database name required")
Expand Down
17 changes: 17 additions & 0 deletions server.go
Original file line number Diff line number Diff line change
Expand Up @@ -855,6 +855,17 @@ func (s *Server) DataNodes() (a []*DataNode) {
return
}

// DropServer removes a server from the cluster
// Curently it will drop both a broker and/or a data node
func (s *Server) DropServer(nodeID uint64) error {
if nodeID == 0 {
return ErrServerNodeIDRequired
}
c := &dropServerCommand{NodeID: nodeID}
_, err := s.broadcast(dropServerMessageType, c)
return err
}

// CreateDataNode creates a new data node with a given URL.
func (s *Server) CreateDataNode(u *url.URL) error {
c := &createDataNodeCommand{URL: u.String()}
Expand Down Expand Up @@ -2159,6 +2170,8 @@ func (s *Server) ExecuteQuery(q *influxql.Query, database string, user *User, ch
res = s.executeDropDatabaseStatement(stmt, user)
case *influxql.ShowDatabasesStatement:
res = s.executeShowDatabasesStatement(stmt, user)
case *influxql.DropServerStatement:
res = s.executeDropServerStatement(stmt, user)
case *influxql.ShowServersStatement:
res = s.executeShowServersStatement(stmt, user)
case *influxql.CreateUserStatement:
Expand Down Expand Up @@ -2436,6 +2449,10 @@ func (s *Server) executeShowDatabasesStatement(q *influxql.ShowDatabasesStatemen
return &Result{Series: []*influxql.Row{row}}
}

func (s *Server) executeDropServerStatement(q *influxql.DropServerStatement, user *User) *Result {
return &Result{Err: s.DropServer(q.NodeID)}
}

func (s *Server) executeShowServersStatement(q *influxql.ShowServersStatement, user *User) *Result {
row := &influxql.Row{Columns: []string{"id", "url"}}
for _, node := range s.DataNodes() {
Expand Down

0 comments on commit ece6247

Please sign in to comment.