Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Explorer: Clicking submit a query is taking too long #18296

Closed
russorat opened this issue May 29, 2020 · 4 comments
Closed

Data Explorer: Clicking submit a query is taking too long #18296

russorat opened this issue May 29, 2020 · 4 comments

Comments

@russorat
Copy link
Contributor

This delay is happening in the data explorer whenever i click the submit button. Clicking the button should register instantly for the user.

image (54)

@desa
Copy link
Contributor

desa commented Jun 12, 2020

@asalem1 does the PR you have solve this issue or just add a cancel button?

@asalem1
Copy link
Contributor

asalem1 commented Jun 16, 2020

Both. It address the issue that clicking submit should immediately set the button value to a loading state rather than waiting for the query to compile and execute. @russorat I just merged the changes onto master if you wanna see if the issue is resolved for you. If it is, feel free to mark it as closed, otherwise let me know and I'll see about speeding the event up some other way

@russorat
Copy link
Contributor Author

This is what i see in the data explorer in us-west this morning. There is still a noticeable delay when interacting with the button.

Kapture 2020-06-16 at 8 29 46

@asalem1
Copy link
Contributor

asalem1 commented Jun 18, 2020

Hmmm, would you mind sending me a link to a dashboard that's experiencing this? We're setting the state on click so I'm not sure where the delay is coming from. We've got a feature enhancement request coming up to half a second until the cancel text displays (so that it doesn't flash so abruptly). I'm wondering if that might help in the perception that the event didn't register?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants