fix: don't re-fetch variables if their loading status is done #18651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoorayimhelping
force-pushed
the
bucky_dont_refetch_variables
branch
from
ef54009 to
0224384
Compare
hoorayimhelping
force-pushed
the
bucky_dont_refetch_variables
branch
from
0224384 to
b68ae0f
Compare
asalem1
approved these changes
Jun 23, 2020
hoorayimhelping
force-pushed
the
bucky_dont_refetch_variables
branch
from
b68ae0f to
910cead
Compare
hoorayimhelping
force-pushed
the
bucky_dont_refetch_variables
branch
from
910cead to
47715b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects #18296
Checks if variables have been loaded and skips the hydration process for any variables that have already been hydrated.
previously note the delay between double clicking the Submit/Cancel button and the cancel notification firing
now cancel button fires immediately*
* I know we're planning on changing it so it doesn't flash, but the flash is actually the indicator that the ui is responsive.