DBRP server implementation does not match swagger specification

[GeorgeMac]

See: https://docs.influxdata.com/influxdb/v2.0/api/#operation/PostDBRP

influxdb/dbrp/http_server_dbrp.go

Lines 58 to 65 in d93560f

	type createDBRPRequest struct {
	Database string `json:"database"`
	RetentionPolicy string `json:"retention_policy"`
	Default bool `json:"default"`
	Org string `json:"organization"`
	OrganizationID influxdb.ID `json:"organization_id"`
	BucketID influxdb.ID `json:"bucket_id"`
	}

The API docs states:

• org
• orgID
• bucketID

But we shorten organization to org, and we use camel-case in the docs / API spec.
Since the docs are the shared source of truth, we should update the implementation.

[danxmoran]

@GeorgeMac I've seen a few people in the community Slack posting curl examples for using this API, I'm wary about changing the implementation and breaking them. It looks like IDPE is in the same situation (swagger here, and struct here). If Swagger is just used for documentation (no codegen), I'd prefer to fix it to match the current behavior.

EDIT: Adam pointed out that we do codegen many clients from the Swagger, sigh...

[danxmoran]

Some more data points / bugs:

• The generated API docs show both org and orgID as both required, when (I believe) it's really one-or-the-other. Code here.
• The DBRP model definition in the API spec is reused for the list endpoint. The model used by the implementation of that endpoint matches the implementation of the create endpoint, so the mismatch occurs there as well:
  

  influxdb/dbrp_mapping.go

  Lines 28 to 38 in d93560f

  	type DBRPMappingV2 struct {
  	ID ID `json:"id"`
  	Database string `json:"database"`
  	RetentionPolicy string `json:"retention_policy"`
  	// Default indicates if this mapping is the default for the cluster and database.
  	Default bool `json:"default"`
  	OrganizationID ID `json:"organization_id"`
  	BucketID ID `json:"bucket_id"`
  	}