Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): make the dbrp api match the swagger spec #20091

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Conversation

docmerlin
Copy link
Contributor

This is to make the DBRP api match the swagger spec.
Closes #20087

The swagger spec is the source of truth for the API, and the DBRP api
was divergent from this spec.  This change should make it meet the spec.
@docmerlin docmerlin changed the title DBRPmatchswagger fix(api): make the dbrp api match the swagger spec Nov 18, 2020
@danxmoran
Copy link
Contributor

Oh wait, need to check client code...

@danxmoran danxmoran self-requested a review November 18, 2020 18:13
@danxmoran
Copy link
Contributor

Hit a panic during manual testing, investigating...

Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Panic seems unrelated, LGTM

@docmerlin docmerlin merged commit 1788b47 into master Nov 18, 2020
@docmerlin docmerlin deleted the DBRPmatchswagger branch November 18, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DBRP server implementation does not match swagger specification
2 participants