Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call WriteHeader more than once #33

Closed
jvshahid opened this issue Nov 11, 2013 · 9 comments
Closed

Don't call WriteHeader more than once #33

jvshahid opened this issue Nov 11, 2013 · 9 comments

Comments

@jvshahid
Copy link
Contributor

This message is all over the logs:

http: multiple response.WriteHeader calls

We shouldn't be calling WriteHeader more than once.

@ghost ghost assigned jvshahid Nov 11, 2013
@jvshahid
Copy link
Contributor Author

jvshahid commented Dec 2, 2013

I don't think this is happening anymore. Closing for now.

@jvshahid jvshahid closed this as completed Dec 2, 2013
@schmurfy
Copy link
Contributor

this bug still exists (or came back), I am not sure how I triggered it but each time I do a get request my console is flooded by this warning (I am running on master).

Edit: I don't have it with 0.4.0 though

@schmurfy
Copy link
Contributor

I spoke too quickly now I have it on 0.4.0 too, I am not sure but it seems linked to parallel requests.
As long as I was only making one request at a time no warning were shown but as soon as I started to play with parallel requests (without reusing the connection) the warning started to show and it seems that when it shows the requests fails from the client point of view.

@toddboom toddboom reopened this Jan 23, 2014
@toddboom
Copy link
Contributor

@schmurfy Thanks for the update. Reopening this and we'll take a look!

@schmurfy
Copy link
Contributor

I get back the no response part, otherwise I tried to narrow down when exactly I get the warning but the end result is.. I have no idea xD

@crosbymichael
Copy link

I get this often when I send an invalid time format.

@jvshahid
Copy link
Contributor Author

Do you still get it with the fix that i just pushed ?

On Thu, Jan 23, 2014 at 5:33 PM, Michael Crosby notifications@github.comwrote:

I get this often when I send an invalid time format.


Reply to this email directly or view it on GitHubhttps://github.com//issues/33#issuecomment-33176878
.

@crosbymichael
Copy link

@jvshahid Sorry, i didn't refresh the issue before posing the comment. I'll test tonight.

@schmurfy
Copy link
Contributor

I'll try to test it too and report here.

jvshahid pushed a commit that referenced this issue Aug 12, 2014
Check checksum before load snapshot
@jvshahid jvshahid removed their assignment Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants