Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "DROP DATABASE IF EXISTS" #4659

Closed
otoolep opened this issue Nov 4, 2015 · 3 comments
Closed

Support "DROP DATABASE IF EXISTS" #4659

otoolep opened this issue Nov 4, 2015 · 3 comments
Labels
difficulty/medium Resolving this issue should take up to a week

Comments

@otoolep
Copy link
Contributor

otoolep commented Nov 4, 2015

This useful command would allow clients to idempotently drop a database. If IF EXISTS is present, no error would be returned if the database does not exist.

#3892 introduced CREATE DATABASE IF NOT EXISTS, so using that PR as a guide, along with investigating the current implementation of DROP DATABASE should make it relatively easy to implement this feature.
@otoolep otoolep added status/help-wanted difficulty/medium Resolving this issue should take up to a week and removed difficulty/low labels Nov 4, 2015
@ch33hau ch33hau mentioned this issue Nov 6, 2015
Merged
@ch33hau
Copy link
Contributor

ch33hau commented Nov 6, 2015

Hi @otoolep , can I have a try for this issue? I have create a pull request for it.
If someone is already working on it then just ignore mine ya

ch33hau added a commit to ch33hau/influxdb that referenced this issue Nov 7, 2015
@ch33hau
Added IF EXISTS for DROP DATABASE command, influxdata#4659
2235dce
otoolep added a commit that referenced this issue Nov 7, 2015
@otoolep
Merge pull request #4698 from ch33hau/drop-database-if-exists
905437c 
Added IF EXISTS for DROP DATABASE command, #4659
@otoolep
Copy link
Contributor Author

otoolep commented Nov 9, 2015

@ch33hau - email me your address so we can send you a tshirt. philip at influxdb

@ch33hau
Copy link
Contributor

ch33hau commented Nov 9, 2015

@otoolep Thanks for your Monday early good news! =)
I have sent my address to your email.

@otoolep otoolep closed this as completed Nov 9, 2015
@EricSmekens EricSmekens mentioned this issue Nov 25, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/medium Resolving this issue should take up to a week
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@otoolep @ch33hau