Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin interface - bad parsing of returned response data #48

Closed
jondot opened this issue Nov 13, 2013 · 4 comments
Closed

Admin interface - bad parsing of returned response data #48

jondot opened this issue Nov 13, 2013 · 4 comments

Comments

@jondot
Copy link
Contributor

jondot commented Nov 13, 2013

I think the server now returns an application/json content-type which didn't exist before.

This causes jQuery to be smart and parse the response. Then a redundant call to JSON.parse over a valid Javascript object (instead of a stringified JSON) kills the parsing.

@jvshahid
Copy link
Contributor

Cool, will take a look into it asap.

@jondot
Copy link
Contributor Author

jondot commented Nov 13, 2013

Thanks!
If you can write a short guideline as to what is developer workflow of fixing problems in admin, moving built assets to main influx project and verifying - I'd be happy to help and fix by those guidelines. As of now I can make a best guess but not sure how it is best done.

@jvshahid
Copy link
Contributor

You don't have to copy the assets. you can simply fork influxdb/influxdb-admin, make the changes test them locally and submit a pr to that repo. influxdb-admin is what gets packaged with influxdb.

@jvshahid
Copy link
Contributor

Fixed. This should be included in the latest package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants