Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a panic when matching on a specific type of regular expression #10094

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Fix a panic when matching on a specific type of regular expression #10094

merged 1 commit into from
Jul 18, 2018
+1 −1

Conversation

jsternberg
Copy link
Contributor

Fixes #10069.

@ghost ghost assigned jsternberg Jul 17, 2018
@ghost ghost added the review label Jul 17, 2018
@hercules-influx
Copy link
Collaborator

During a run of megacheck the following issues were discovered:

jsternberg added a commit that referenced this pull request Jul 17, 2018
@jsternberg
Fix a panic when matching on a specific type of regular expression
9bd1d12 
Backport of #10094.
@jsternberg jsternberg mentioned this pull request Jul 17, 2018
Merged
@jsternberg jsternberg modified the milestone: 1.6.1 Jul 17, 2018
e-dard
e-dard approved these changes Jul 17, 2018
View reviewed changes
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e-dard
Copy link
Contributor

e-dard commented Jul 18, 2018

@jsternberg don't we want this to appear in the 1.6.1 CHANGELOG rather than the 1.7 CHANGELOG? Should the kind/bug label be on the backport PR?

@jsternberg
Copy link
Contributor Author

It should be in both sections so this is fine. The kind/bug label should be on the backport PR and I forgot so I added that before merging.

@jsternberg jsternberg merged commit 0e87135 into master Jul 18, 2018
@ghost ghost removed the review label Jul 18, 2018
@jsternberg jsternberg deleted the js-10069-regex-parsing-panic branch July 18, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-dard e-dard

Assignees

@jsternberg jsternberg

Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsternberg @hercules-influx @e-dard