Backport #10549: Pass the query authorizer to subqueries #10559
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query authorizer was not being properly passed to subqueries so rejections did not happen when a subquery was the one reading the value. Similarly, the max series limit was not being propagated downwards either. The original change modified query/subquery_test.go, but the 1.5 branch does not have the file, and appeared to be unable to compile that file as it appeared originally; so this backport does not include the test.
ghost
assigned 
stuartcarnie
approved these changes
Dec 11, 2018
mark-rushakoff
deleted the
bp15-js-pass-query-authorizer-to-subqueries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query authorizer was not being properly passed to subqueries so
rejections did not happen when a subquery was the one reading the value.
Similarly, the max series limit was not being propagated downwards
either.
The original change modified query/subquery_test.go, but the 1.5 branch
does not have the file, and appeared to be unable to compile that file
as it appeared originally; so this backport does not include the test.