Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui/dataLoaders): Move plugins sidebar into only collectors configure step #11705

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

ischolten
Copy link
Contributor

@ischolten ischolten commented Feb 6, 2019

Closes #11610
Closes #11684

Briefly describe your proposed changes:
Moves the plugins side bar into only the configure step of the collectors wizard. Plugins are no longer visible in the verify step.
Additionally removes some styling that pushes the configure step buttons off to the side.

  • Rebased/mergeable
  • Tests pass
  • Update Changelog
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@ischolten ischolten force-pushed the fix/plugins-configure-only branch from d373189 to f45cb62 Compare February 6, 2019 01:27
@ischolten ischolten force-pushed the fix/plugins-configure-only branch from f45cb62 to 2e629da Compare February 6, 2019 17:35
…ure step

Co-authored-by: Daniel Campbell <metalwhirlwind@gmail.com>
@ischolten ischolten force-pushed the fix/plugins-configure-only branch from 2e629da to 1f81218 Compare February 6, 2019 17:43
@ischolten ischolten merged commit 8b991e5 into master Feb 6, 2019
@ischolten ischolten deleted the fix/plugins-configure-only branch February 6, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants