fix(ui): show checked on multidropdown #11711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OfTheDelmer
force-pushed
the
fix/11538
branch
from
7e75e53
to
1146f60
Compare
OfTheDelmer
commented
Feb 6, 2019
| @@ -58,7 +58,9 @@ class DashboardsDropdown extends PureComponent<Props> { | |||
| } | |||
|
|
|||
| private get dividerItem(): JSX.Element { | |||
| return <MultiSelectDropdown.Divider key={0} /> | |||
There was a problem hiding this comment.
the default for a new dashboard has id of 0 and key of 0 so this was causing a key collision
chnn
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11538
Briefly describe your proposed changes:
Show style for selected items in multi select dropdown