Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TasksList to display last run date #11824

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Update TasksList to display last run date #11824

merged 1 commit into from
Feb 12, 2019

Conversation

Palakp41
Copy link
Contributor

@Palakp41 Palakp41 commented Feb 12, 2019 •
edited
Loading

Closes #10902

Briefly describe your proposed changes:
Update tasks list and task row to display the new column for last completed task run

  • Rebased/mergeable
  • Tests pass

chnn
chnn approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@chnn chnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I'm worried that sorting by the "Last Completed" column might be broken, but I can't tell by just looking at the code.

ui/src/tasks/components/TasksList.tsx Outdated Show resolved Hide resolved
@Palakp41 Palakp41 merged commit 08b658b into master Feb 12, 2019
@Palakp41 Palakp41 deleted the feat/tasks-add-lastupdated branch February 12, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chnn chnn chnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Palakp41 @chnn