-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): add label from resource labels editor #11973
Conversation
f53fcb3
to
e1b02b3
Compare
Co-authored-by: Daniel Campbell <metalwhirlwind@gmail.com>
Fixes label selection being blocked by labels menu dropdown and adds margins to labels menu items. Co-authored-by: Daniel Campbell <metalwhirlwind@gmail.com>
e1b02b3
to
aa97075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff.
I left one small comment. I also think that the top of the create label form could using some padding within the dropdown menu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you update the screenshot to reflect the design changes?
Closes #11978 |
a271f68
to
fa66964
Compare
Closes #11624
Briefly describe your proposed changes:
Add resource label creation form when label is not present. Tune label filtering to not aggressively match labels not in the list to more easily enable user to create a new label. Add a random color button instead of a color dropdown which does not work well in the label list dropdown.