Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui/resourceLabelForm): fix ResourceLabelForm invalid default #12057

Merged
merged 1 commit into from
Feb 21, 2019
Merged

fix(ui/resourceLabelForm): fix ResourceLabelForm invalid default #12057

merged 1 commit into from
Feb 21, 2019

Conversation

OfTheDelmer
Copy link
Contributor

@OfTheDelmer OfTheDelmer commented Feb 21, 2019 •
edited
Loading

Closes #12056

Briefly describe your proposed changes:
Wrong default was set for form state.invalid and padding was required instead of margin.

  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)
    screen shot 2019-02-21 at 12 38 30 pm

alexpaxton
alexpaxton approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@alexpaxton alexpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexpaxton alexpaxton merged commit a8bdc9c into master Feb 21, 2019
@alexpaxton alexpaxton deleted the fix/12056 branch February 21, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpaxton alexpaxton alexpaxton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OfTheDelmer @alexpaxton