Polish/scraper overlay #12317
Merged
Polish/scraper overlay #12317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Iris Scholten <ischolten.is@gmail.com>
Co-Authored-By: Iris Scholten <ischolten.is@gmail.com>
Co-Authored-By: Iris Scholten <ischolten.is@gmail.com>
Co-Authored-By: Iris Scholten <ischolten.is@gmail.com>
…ets exist Co-Authored-By: Iris Scholten <ischolten.is@gmail.com>
Co-Authored-By: Iris Scholten <ischolten.is@gmail.com>
Co-Authored-By: Iris Scholten <ischolten.is@gmail.com>
Co-Authored-By: Iris Scholten <ischolten.is@gmail.com>
Co-Authored-By: Iris Scholten <ischolten.is@gmail.com>
Palakp41
reviewed
Mar 4, 2019
| } = this.props | ||
|
|
||
| return ( | ||
| <OverlayContainer maxWidth={600}> |
Palakp41
reviewed
Mar 4, 2019
| icon?: IconFont | ||
| } | ||
|
|
||
| const Alert: SFC<Props> = ({children, color, icon}) => { |
There was a problem hiding this comment.
Yay an alert component! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12310
Change the design of the create scraper overlay to be more consistent with other overlays
Remove UI elements from when the form was inside onboarding
Construct a scraper object in overlay local state instead of using redux to store
Delete vestigial scraper creation components
Introduce clockface
AlertcomponentShow alert in Telegrafs and Scrapers page when user has no buckets
Disabled
Createbutton in Telegrafs and Scrapers page when user has no bucketsUpdate E2E tests
Checklist