feat(ui/dash/import): create dashboards from imported templates #12496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| onDismissOverlay={this.handleToggleImportOverlay} | ||
| onSubmit={this.handleImportDashboard} | ||
| orgID={get(orgs, '0.id', '')} |
There was a problem hiding this comment.
Why is this defaulting to the first org? Shouldn't we let the user select org?
There was a problem hiding this comment.
this is defaulting to the first org since that's what creating a dashboard does. In a separate pr, i will add an org dropdown to the import overlay so that a user may choose.
| </OverlayTechnology> | ||
| <ImportDashboardOverlay | ||
| onDismissOverlay={this.handleToggleOverlay} | ||
| orgID={_.get(orgs, '0.id', '')} |
There was a problem hiding this comment.
same comment as above
| return ( | ||
| <Button | ||
| text={`Import JSON as ${resourceName}`} | ||
| onClick={this.submit} |
There was a problem hiding this comment.
Can we make a card about this not being a form?
There was a problem hiding this comment.
there already is one: #12306
bthesorceror
approved these changes
Mar 11, 2019
ischolten
force-pushed
the
feat/import-dashboard
branch
from
71e7c1e
to
9114362
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11533
Briefly describe your proposed changes:
Create a dashboard from the imported dashboard.
Make import button in import overlay visible and disabled rather than not visible