Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the scrapers and variables empty state to match other org views #12764

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Update the scrapers and variables empty state to match other org views #12764

merged 1 commit into from
Mar 20, 2019

Conversation

ischolten
Copy link
Contributor

@ischolten ischolten commented Mar 19, 2019 •
edited
Loading

Closes #12659

Briefly describe your proposed changes:
Updates the grey box in the scrapers empty state to be the full width
Larger scrapers empty state text
Update variables create button to be smaller

Screen Shot 2019-03-19 at 4 39 00 PM

Screen Shot 2019-03-19 at 4 39 44 PM

  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@ischolten ischolten force-pushed the fix/empty-scrapers-style branch from 4e4d627 to 452dd5a Compare March 19, 2019 23:31
@ischolten ischolten merged commit 6a41856 into master Mar 20, 2019
@ischolten ischolten deleted the fix/empty-scrapers-style branch March 20, 2019 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavarius mavarius mavarius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ischolten @mavarius