Improve display of query errors #12826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavarius
approved these changes
Mar 22, 2019
| <div className="cell--view-empty" data-testid={testID}> | ||
| <div className="empty-graph-error"> | ||
| <CopyToClipboard text={message}> | ||
| <Button |
There was a problem hiding this comment.
Speak with @ischolten about standardizing copy to clipboard implementation across the application.
There was a problem hiding this comment.
Will do. I first tried using the CodeSnippet component used in the Telegraf configuration screen. The always-visible big purple "Copy to Clipboard" button felt out of place on the dashboard, which is why I created yet another way of doing the same thing :|
Co-authored-by: Alex Paxton <thealexpaxton@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12686
Also tweaks the query execution code to check for error messages that appear as a Flux table. Previously we ignored these errors and attempted to plot the data anyway.