Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to clone a template #12910

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Add the ability to clone a template #12910

merged 1 commit into from
Mar 26, 2019

Conversation

Palakp41
Copy link
Contributor

@Palakp41 Palakp41 commented Mar 26, 2019 •
edited
Loading

Closes #12741

Briefly describe your proposed changes:
Updated the client to include the clone function
Updated actions and reducers to add the cloned template to the redux state
Updated Template card to include clone button

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

Kapture 2019-03-26 at 14 05 42

@Palakp41 Palakp41 force-pushed the feat/templates-clone branch 2 times, most recently from 44b79f3 to 42eba65 Compare March 26, 2019 21:37
alexpaxton
alexpaxton approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@alexpaxton alexpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

ui/src/templates/actions/index.ts Outdated Show resolved Hide resolved
@Palakp41 Palakp41 force-pushed the feat/templates-clone branch from 42eba65 to aa79a26 Compare March 26, 2019 22:32
@Palakp41 Palakp41 merged commit e227192 into master Mar 26, 2019
@Palakp41 Palakp41 deleted the feat/templates-clone branch May 21, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthesorceror bthesorceror bthesorceror left review comments

@alexpaxton alexpaxton alexpaxton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Palakp41 @bthesorceror @alexpaxton