update task schedler to use the new task control service #12949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyondhill
force-pushed
the
task/scheduler-control-service
branch
from
c19d393
to
b65d57d
Compare
lyondhill
force-pushed
the
task/scheduler-control-service
branch
from
b65d57d
to
9272175
Compare
lyondhill
force-pushed
the
task/scheduler-control-service
branch
from
cb172c9
to
1880e54
Compare
mark-rushakoff
suggested changes
Mar 28, 2019
There was a problem hiding this comment.
Looking good overall. The couple things that need to change:
- Call to FinishRun in the scheduler that was extracted to a defer needs to be undone.
- There are a lot of new calls to
time.Parsethat discard the error. I didn't comment on them. They must check the error. What will happen to the system if a bad timestamp slips in there somehow? - There are some new and existing maps that have ID keys as strings; the code will be a little simpler and shorter by just using influxdb.ID as the keys without converting to/from strings.
mark-rushakoff
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12725