Remove the old bolt implementation #12974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhulongcheng
force-pushed
the
rm-bolt-inmem-impl
branch
8 times, most recently
from
3d54011 to
f6cc0e8
Compare
zhulongcheng
changed the title
|
Looks good to me. @desa could you take a look at the metrics part? |
zhulongcheng
force-pushed
the
rm-bolt-inmem-impl
branch
from
4e158e5 to
d8ba1d4
Compare
goller
reviewed
May 13, 2019
| "github.com/influxdata/influxdb/kit/prom/promtest" | ||
| ) | ||
|
|
||
| func TestInitialKVStoreMetrics(t *testing.T) { |
There was a problem hiding this comment.
Hey @zhulongcheng , would you try to port the existing metrics_test.go code here?
I'd like to make sure the metrics are coming out correctly
zhulongcheng
force-pushed
the
rm-bolt-inmem-impl
branch
from
d8ba1d4 to
c496f01
Compare
zhulongcheng
force-pushed
the
rm-bolt-inmem-impl
branch
from
1718268 to
f1b67c0
Compare
zhulongcheng
force-pushed
the
rm-bolt-inmem-impl
branch
from
b7a38e9 to
ce17d90
Compare
zhulongcheng
force-pushed
the
rm-bolt-inmem-impl
branch
3 times, most recently
from
4a3d810 to
58343dc
Compare
zhulongcheng
force-pushed
the
rm-bolt-inmem-impl
branch
from
58343dc to
bb20657
Compare
zhulongcheng
force-pushed
the
rm-bolt-inmem-impl
branch
4 times, most recently
from
f9277ec to
0807706
Compare
zhulongcheng
force-pushed
the
rm-bolt-inmem-impl
branch
from
0807706 to
6313dd2
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed because it has not had recent activity. Please reopen if this issue is still important to you. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13030
Steps to remove the old bolt implementation:
KVStore.Describe,KVStore.Collectandkv.Service.IDmethods// register and collect prometheus metrics
bolt.Clientwithbolt.KVStorebolt.Client// after
Step-2, thebolt.Clientis unused, so it can be removedSpecial notes:
The
example_test.goas a duplicate oftesting/keyvalue_log.go, so was removed.Briefly describe your proposed changes: