Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set autorefresh of dashboard to pause if absolute time range is selected #13423

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Set autorefresh of dashboard to pause if absolute time range is selected #13423

merged 1 commit into from
Apr 16, 2019

Conversation

ischolten
Copy link
Contributor

@ischolten ischolten commented Apr 16, 2019 •
edited
Loading

Closes #13048

Briefly describe your proposed changes:
when absolute time range is selected, the dashboard's auto refresh should get disabled
autorefresh is by dashboard rather than global
autorefresh for time machine is stored in redux rather than local state

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@ischolten ischolten force-pushed the disable-autorefresh-timerange branch 2 times, most recently from 1ed7d45 to 42f85ff Compare April 16, 2019 00:40
@ischolten ischolten changed the title Disable autorefresh timerange Set autorefresh of dashboard to pause if absolute time range is selected Apr 16, 2019
@ischolten ischolten force-pushed the disable-autorefresh-timerange branch 5 times, most recently from 58088f9 to 831338f Compare April 16, 2019 01:04
121watts
121watts approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@121watts 121watts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change the things we talked about offline and 🚢

@ischolten ischolten force-pushed the disable-autorefresh-timerange branch from 831338f to a14e64a Compare April 16, 2019 17:45
@ischolten ischolten merged commit 5487ed6 into master Apr 16, 2019
@ischolten ischolten deleted the disable-autorefresh-timerange branch April 16, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@121watts 121watts 121watts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable auto refresh when selecting an absolute time range
2 participants
@ischolten @121watts