Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dropdown Overlapping Dot & Text #13585

Merged
merged 2 commits into from
Apr 23, 2019
Merged

Fix Dropdown Overlapping Dot & Text #13585

merged 2 commits into from
Apr 23, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Apr 23, 2019 •
edited
Loading

Closes #13341

Only add dropdown--action classname (which removes padding for dots) if there is no selectedID prop

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@alexpaxton alexpaxton merged commit 17caffe into master Apr 23, 2019
@alexpaxton alexpaxton deleted the fix/dropdown-dots-overlapping branch April 23, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthesorceror bthesorceror bthesorceror approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time range dropdown selected dot overlaps with text
2 participants
@alexpaxton @bthesorceror