feat(tasks): add description field to tasks #13850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlirieGray
force-pushed
the
add-description-to-tasks
branch
3 times, most recently
from
c8294a2
to
dcbf21a
Compare
http/task_service_test.go
Outdated
| @@ -137,7 +138,8 @@ func TestTaskHandler_handleGetTasks(t *testing.T) { | |||
| }, | |||
| "id": "0000000000000001", | |||
| "name": "task1", | |||
| "labels": [ | |||
| "description: "A little Task", | |||
There was a problem hiding this comment.
"description -> "description" will fix the test failure
AlirieGray
force-pushed
the
add-description-to-tasks
branch
from
dcbf21a
to
d063dfa
Compare
imogenkinsman
approved these changes
May 8, 2019
AlirieGray
force-pushed
the
add-description-to-tasks
branch
from
d063dfa
to
dbb1f02
Compare
imogenkinsman
suggested changes
May 8, 2019
AlirieGray
force-pushed
the
add-description-to-tasks
branch
from
dbb1f02
to
c4d3a84
Compare
imogenkinsman
approved these changes
May 8, 2019
task.go
Outdated
| @@ -133,6 +134,7 @@ type TaskService interface { | |||
| // TaskCreate is the set of values to create a task. | |||
| type TaskCreate struct { | |||
| Flux string `json:"flux"` | |||
| Description string `json:description,omitempty` | |||
There was a problem hiding this comment.
json:"description,omitempty"
AlirieGray
force-pushed
the
add-description-to-tasks
branch
3 times, most recently
from
52e83e3
to
10a1c6e
Compare
AlirieGray
force-pushed
the
add-description-to-tasks
branch
from
10a1c6e
to
77934b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12386
This PR adds a
Descriptionproperty to Tasks in the Swagger definition as well as in the API.