Add x and y column pickers to graph types #14052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebb-tide
changed the title
chnn
reviewed
Jun 3, 2019
There was a problem hiding this comment.
Hey I think we need to feature flag the API changes to ensure we can deploy this safely.
I'm also thinking we should remove effects (useEffect) from both the ScatterContainer and XYContainer, but maybe I'm missing why they are needed. Left some comments about that.
ebb-tide
force-pushed
the
select-x-y-columns
branch
from
48fb5c2
to
894a880
Compare
ebb-tide
force-pushed
the
select-x-y-columns
branch
from
00592e3
to
7cc1c66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14024