Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add x and y column pickers to graph types #14052

Merged
merged 14 commits into from
Jun 5, 2019
Merged

Add x and y column pickers to graph types #14052

merged 14 commits into from
Jun 5, 2019

Conversation

ebb-tide
Copy link
Contributor

@ebb-tide ebb-tide commented Jun 3, 2019 •
edited
Loading

Closes #14024

@ebb-tide ebb-tide changed the title Add x and y column picker to line graph Add x and y column pickers to graph types Jun 3, 2019
@ebb-tide ebb-tide requested a review from chnn June 3, 2019 20:05
chnn
chnn reviewed Jun 3, 2019
View reviewed changes
Copy link
Contributor

@chnn chnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I think we need to feature flag the API changes to ensure we can deploy this safely.

I'm also thinking we should remove effects (useEffect) from both the ScatterContainer and XYContainer, but maybe I'm missing why they are needed. Left some comments about that.

ui/src/timeMachine/components/view_options/HeatmapOptions.tsx Show resolved Hide resolved
ui/src/shared/components/ScatterContainer.tsx Outdated Show resolved Hide resolved
ui/src/shared/components/XYContainer.tsx Outdated Show resolved Hide resolved
ui/src/shared/components/ScatterContainer.tsx Outdated Show resolved Hide resolved
ui/src/shared/components/ScatterContainer.tsx Show resolved Hide resolved
ui/src/shared/components/XYContainer.tsx Outdated Show resolved Hide resolved
dashboard.go Show resolved Hide resolved
@ebb-tide ebb-tide force-pushed the select-x-y-columns branch from 48fb5c2 to 894a880 Compare June 4, 2019 20:29
chnn
chnn reviewed Jun 4, 2019
View reviewed changes
Copy link
Contributor

@chnn chnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good except for a bug.

ui/src/timeMachine/selectors/index.ts Outdated Show resolved Hide resolved
ui/src/shared/components/XYContainer.tsx Show resolved Hide resolved
chnn
chnn approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@chnn chnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot :)

ebb-tide added 14 commits June 4, 2019 17:50
@ebb-tide ebb-tide force-pushed the select-x-y-columns branch from 00592e3 to 7cc1c66 Compare June 5, 2019 00:50
@ebb-tide ebb-tide merged commit 9edf9bd into master Jun 5, 2019
@ebb-tide ebb-tide deleted the select-x-y-columns branch June 5, 2019 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chnn chnn chnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow user to select y-axis Column to plot in the vis library
2 participants
@ebb-tide @chnn