Add influxd verify tsm-blocks #14243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartcarnie
force-pushed
the
sgc/verify
branch
2 times, most recently
from
2ab3817
to
86a9803
Compare
stuartcarnie
force-pushed
the
sgc/verify
branch
2 times, most recently
from
025a624
to
07d3c44
Compare
e-dard
suggested changes
Jul 3, 2019
There was a problem hiding this comment.
Thanks for this. I want all inspection tooling though to provide an exported API, so it can be called programatically. Here is a canonical example: #11964
I guess I would expect the API to live in tsdb/tsm1/verify.go or somewhere similar?
Also, when this is done it can be ticked off this list 😄 #10993
|
Feedback done, @e-dard |
3 tasks
benbjohnson
approved these changes
Jul 8, 2019
This command performs verification of TSM blocks * expected and actual CRC-32 checksums match * expected and actual min and max timestamps match decoded data
Should have left it there to begin with 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command verifies
Example usages
Verify all tsm files in
~/tmp/storage/5:$ influxd inspect verify-tsm ~/tmp/storage/5Verify specific tsm file:
$ influxd inspect verify-tsm ~/tmp/storage/5/000000515941663-000000007.tsmVerify all tsm files, limiting to a specific org:
$ influxd inspect verify-tsm --org-id=099683d2af6fba05 ~/tmp/storage/5/