Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tasks): surface flux errors on pre auth check #14492

Merged
merged 7 commits into from
Jul 31, 2019

Conversation

GeorgeMac
Copy link
Contributor

@GeorgeMac GeorgeMac commented Jul 29, 2019

Closes #14449

This change comprises of a few cosmetic changes to the way the create tasks action surfaces errors. Prior to this change, unnecessary wrapping of platform errors caused the frontend to present unhelpful error messages when failures occured compiling the flux script in a preauth check.

This change ensures that platform errors don't get wrapped more than once during a create task action. It also adds a few more tests throughout to capture this behavior.

See new cypress test for an example of a missing org: in the to() function call and how the necessary detailed information is now presented to the user. Prior to this all errors here were presented as a failure to authenticate.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@GeorgeMac GeorgeMac requested a review from a team July 29, 2019 17:52
@ghost ghost requested review from AlirieGray and removed request for a team July 29, 2019 17:52
@AlirieGray
Copy link
Contributor

AlirieGray commented Jul 29, 2019

looks good to me! only thing is the linter error. if you don't already have Prettier installed, I think that will take care of JS linting for you so you don't have to think about it.

@GeorgeMac
Copy link
Contributor Author

Cheers for the tip @AlirieGray !

@GeorgeMac GeorgeMac self-assigned this Jul 30, 2019
@GeorgeMac GeorgeMac merged commit b2fe0d1 into master Jul 31, 2019
@GeorgeMac GeorgeMac deleted the gm/tasks-surface-flux-compile-errors branch July 31, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preauthorization For Tasks Supresses Useful Error Context
2 participants