Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): adding new templates, removing calls to create templates #14631

Merged
merged 12 commits into from
Aug 14, 2019

Conversation

russorat
Copy link
Contributor

@russorat russorat commented Aug 12, 2019

Closes influxdata/influxdb-templates#9
Closes #14505

Describe your proposed changes here.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@russorat russorat requested a review from ebb-tide August 12, 2019 23:30
@russorat russorat requested review from a team as code owners August 13, 2019 23:56
@ebb-tide ebb-tide requested a review from chnn August 13, 2019 23:57
Copy link
Contributor

@chnn chnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like reasonable changes to me, though I'm not very familiar with all the templates logic.

One thing I didn't understand and couldn't figure out from the linked issues: what's the purpose of the templateID? It looks like they are client-controlled/hardcoded IDs in the influxdb-templates package, yet the IDs are in a format that the InfluxDB API generates. What's up with that?

ui/src/onboarding/actions/index.ts Show resolved Hide resolved
@ebb-tide
Copy link
Contributor

I went back and forth on whether templateIDs should be more human-readable or influxdbID format- and decided that we might want a way to auto-generate IDs at some point, so wanted to be compatible with that posssibility.
context:
#14082
#14100
#14101
#14102

@russorat russorat changed the title feat(templates): adding new templates; removing calls to create templates feat(templates): adding new templates, removing calls to create templates Aug 14, 2019
@russorat russorat merged commit 8a5d0e6 into master Aug 14, 2019
@russorat russorat deleted the feat/update-templates branch August 14, 2019 18:01
@chnn
Copy link
Contributor

chnn commented Aug 14, 2019

Ok cool, that makes a lot more sense now. Thanks for the background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove calls to create templates in a new org. Update the name of the Local Metrics Template
3 participants