-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(templates): adding new templates, removing calls to create templates #14631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like reasonable changes to me, though I'm not very familiar with all the templates logic.
One thing I didn't understand and couldn't figure out from the linked issues: what's the purpose of the templateID
? It looks like they are client-controlled/hardcoded IDs in the influxdb-templates
package, yet the IDs are in a format that the InfluxDB API generates. What's up with that?
Ok cool, that makes a lot more sense now. Thanks for the background. |
Closes influxdata/influxdb-templates#9
Closes #14505
Describe your proposed changes here.