feat(task): Add task middleware's for checks and notifications #14809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyondhill
force-pushed
the
task/middlewares
branch
from
bbf92be
to
fd9fc42
Compare
To have checks and notifications happen transactionally we need to be able to alert the task system when a new task was created using the checks and notifications systems. These two new middlewares allow us to inform the task system of a update to a task that was created through the check or notification systems.
lyondhill
force-pushed
the
task/middlewares
branch
from
fd9fc42
to
fc0d236
Compare
ghost
requested review from
AlirieGray
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have checks and notifications happen transactionally we need to be
able to alert the task system when a new task was created using the checks and notifications systems.
These two new middleware's allow us to inform the task system of a update
to a task that was created through the check or notification systems.