Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): expose bucket options as buttons instead of context menu #14889

Merged
merged 3 commits into from
Aug 30, 2019
Merged

refactor(ui): expose bucket options as buttons instead of context menu #14889

merged 3 commits into from
Aug 30, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Aug 30, 2019 •
edited
Loading

Describe your proposed changes here.

  • Move Rename , Add Data, and Delete Data by Filter into resource card instead of context menu
  • Use Clockface Popover for Add Data button

Why

Despite making each bucket card a bit busier, I predict this change will make the options more discoverable and faster to access.

updated-bucket-list

@alexpaxton alexpaxton requested a review from a team August 30, 2019 18:41
@ghost ghost requested review from chnn and removed request for a team August 30, 2019 18:41
chnn
chnn approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@chnn chnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purple button seems a bit scrunched up against the text above it, but otherwise looks awesome.

@alexpaxton alexpaxton merged commit 25c1194 into master Aug 30, 2019
@alexpaxton alexpaxton deleted the refactor/buckets-list-design branch August 30, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chnn chnn chnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexpaxton @chnn