Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): settings navigation #14990

Merged
merged 5 commits into from
Sep 5, 2019
Merged

refactor(ui): settings navigation #14990

merged 5 commits into from
Sep 5, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Sep 5, 2019 •
edited
Loading

  • Move Tokens tab to Load Data page
  • Expose all Settings tabs in nav menu
  • Prefix all settings page URLS with settings/

Screen Shot 2019-09-05 at 3 29 23 PM
Screen Shot 2019-09-05 at 3 29 26 PM

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@alexpaxton alexpaxton requested a review from a team September 5, 2019 22:31
@ghost ghost requested review from ebb-tide and removed request for a team September 5, 2019 22:31
@alexpaxton alexpaxton requested a review from a team September 5, 2019 22:48
@ghost ghost removed their request for review September 5, 2019 22:48
@alexpaxton alexpaxton merged commit 77a5953 into master Sep 5, 2019
@alexpaxton alexpaxton deleted the refactor/settings-nav branch September 5, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@121watts 121watts 121watts approved these changes

@ebb-tide ebb-tide Awaiting requested review from ebb-tide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexpaxton @121watts