Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): Ensures users are created with an active status #15295

Merged
merged 1 commit into from
Oct 1, 2019
Merged

fix(http): Ensures users are created with an active status #15295

merged 1 commit into from
Oct 1, 2019

Conversation

dearyhud
Copy link
Contributor

@dearyhud dearyhud commented Sep 27, 2019 •
edited
Loading

Closes #15274

Adds active as the default status for the user response.

@dearyhud dearyhud force-pushed the fix/http-default-empty-user-status branch from f1150ca to d318c20 Compare September 27, 2019 18:55
@dearyhud dearyhud requested a review from a team September 27, 2019 18:58
kelwang
kelwang suggested changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@kelwang kelwang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the logic in kv layer.

http/user_service.go Outdated Show resolved Hide resolved
@dearyhud dearyhud force-pushed the fix/http-default-empty-user-status branch from d318c20 to a002c42 Compare September 27, 2019 20:54
@dearyhud dearyhud changed the title fix(http): add default status for user response fix(http): sets a default status for user response Sep 30, 2019
@dearyhud dearyhud changed the title fix(http): sets a default status for user response fix(http): sets a default status for users Sep 30, 2019
@dearyhud dearyhud force-pushed the fix/http-default-empty-user-status branch from f5e5d7d to bd7c4da Compare September 30, 2019 22:38
@dearyhud dearyhud changed the title fix(http): sets a default status for users fix(http): Ensures users are created with an active status Oct 1, 2019
@dearyhud dearyhud merged commit 4f7e147 into master Oct 1, 2019
@mark-rushakoff mark-rushakoff deleted the fix/http-default-empty-user-status branch April 16, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelwang kelwang kelwang approved these changes

Assignees
No one assigned
Labels
team/api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET http://localhost:9999/api/v2/me returns empty user status
2 participants
@dearyhud @kelwang